From 0ba3b7b9baa5b827577dbbe2e51b4a9ab9cdb036 Mon Sep 17 00:00:00 2001 From: Robert Date: Sun, 17 Mar 2024 19:43:21 +0700 Subject: [PATCH] proper raise --- chain_service/controllers/chain.py | 14 +++++++------- chain_service/controllers/namespace.py | 6 +++--- chain_service/controllers/run_chain.py | 4 ++-- chain_service/controllers/s3.py | 2 +- 4 files changed, 13 insertions(+), 13 deletions(-) diff --git a/chain_service/controllers/chain.py b/chain_service/controllers/chain.py index 5821af0..cf5092e 100644 --- a/chain_service/controllers/chain.py +++ b/chain_service/controllers/chain.py @@ -29,11 +29,11 @@ async def chain_upsert_controller( except AssertionError: logger.exception(f"Unknown namespace_id {chain.namespace_id}") - return HTTPException(status_code=400, detail="Wrong namespace_id") + raise HTTPException(status_code=400, detail="Wrong namespace_id") except Exception: logger.exception(f"Error during chain upsert {chain.model_dump_json()}") - return HTTPException(status_code=500, detail="Error during chain upsert") + raise HTTPException(status_code=500, detail="Error during chain upsert") @router.get("/list") @@ -50,11 +50,11 @@ async def chain_list_controller( except AssertionError: logger.exception(f"Unknown namespace_id {namespace_id}") - return HTTPException(status_code=400, detail="Wrong namespace_id") + raise HTTPException(status_code=400, detail="Wrong namespace_id") except Exception: logger.exception("Error during chain list") - return HTTPException(status_code=500, detail="Error during chain list") + raise HTTPException(status_code=500, detail="Error during chain list") @router.get("/{chain_id}") @@ -67,11 +67,11 @@ async def chain_get_controller( except AssertionError: logger.warning(f"Chain not found {chain_id}") - return HTTPException(status_code=404, detail="Chain not found") + raise HTTPException(status_code=404, detail="Chain not found") except Exception: logger.exception("Error during chain get") - return HTTPException(status_code=500, detail="Error during chain get") + raise HTTPException(status_code=500, detail="Error during chain get") @router.delete("/delete/{chain_id}") @@ -84,4 +84,4 @@ async def chain_delete_controller( except Exception: logger.exception("Error during chain deletion") - return HTTPException(status_code=500, detail="Error during chain deletion") + raise HTTPException(status_code=500, detail="Error during chain deletion") diff --git a/chain_service/controllers/namespace.py b/chain_service/controllers/namespace.py index d706e49..0cb1199 100644 --- a/chain_service/controllers/namespace.py +++ b/chain_service/controllers/namespace.py @@ -20,7 +20,7 @@ async def namespace_controller( except Exception: logger.exception(f"Error during namespace upsert {namespace.model_dump_json()}") - return HTTPException(status_code=500, detail="Error during namespace upsert") + raise HTTPException(status_code=500, detail="Error during namespace upsert") # @router.get("/{namespace_name}") @@ -33,8 +33,8 @@ async def namespace_get_by_name_controller( except AssertionError: logger.warning(f"Namespace not found {namespace_name}") - return HTTPException(status_code=404, detail="Namespace not found") + raise HTTPException(status_code=404, detail="Namespace not found") except Exception: logger.exception("Error during chain get") - return HTTPException(status_code=500, detail="Error during namespace get") + raise HTTPException(status_code=500, detail="Error during namespace get") diff --git a/chain_service/controllers/run_chain.py b/chain_service/controllers/run_chain.py index bd3a359..7b50981 100644 --- a/chain_service/controllers/run_chain.py +++ b/chain_service/controllers/run_chain.py @@ -42,8 +42,8 @@ async def run_chain_controller( except AssertionError: logger.warning(f"Chain not found {run_chain_input.chain_id}") - return HTTPException(status_code=404, detail="Chain not found") + raise HTTPException(status_code=404, detail="Chain not found") except Exception: logger.exception("Error during run chain") - return HTTPException(status_code=500, detail="Error during run chain") + raise HTTPException(status_code=500, detail="Error during run chain") diff --git a/chain_service/controllers/s3.py b/chain_service/controllers/s3.py index 493cc90..493be34 100644 --- a/chain_service/controllers/s3.py +++ b/chain_service/controllers/s3.py @@ -25,4 +25,4 @@ async def s3_controller(file: UploadFile): except Exception: logger.exception("Error during s3 upload") - return HTTPException(status_code=500, detail="Cannot upload") + raise HTTPException(status_code=500, detail="Cannot upload")