From 7edd836a75f3609f857f5a9a64f55ada60bb4433 Mon Sep 17 00:00:00 2001 From: Kuroshini Date: Tue, 31 Dec 2019 01:22:45 +0300 Subject: [PATCH] helping hand representation --- apps/news/tasks.py | 2 ++ apps/notification/models.py | 1 + apps/notification/urls/back.py | 1 + apps/notification/views/common.py | 1 + project/urls/back.py | 1 + 5 files changed, 6 insertions(+) create mode 100644 apps/notification/urls/back.py diff --git a/apps/news/tasks.py b/apps/news/tasks.py index 80a2a626..c08ee8c7 100644 --- a/apps/news/tasks.py +++ b/apps/news/tasks.py @@ -26,6 +26,8 @@ def send_email_with_news(news_ids): for subscriber in subscribers: socials_for_subscriber = socials.get(subscriber.country_code) try: + # TODO: вот тут надо учесть, подписки на какие страны есть у юзера активные (нулл время отписки) и не посылать лишнего + # TODO: обрати внимание на кол-во запросов в БД плс. они пишутся в консоль for new in sent_news: context = { "title": new.title.get(subscriber.locale), diff --git a/apps/notification/models.py b/apps/notification/models.py index d1ebf055..3a9dbbf2 100644 --- a/apps/notification/models.py +++ b/apps/notification/models.py @@ -15,6 +15,7 @@ class SubscriptionType(ProjectBaseMixin, TranslatedFieldsMixin): name = TJSONField(blank=True, null=True, default=None, verbose_name=_('name'), help_text='{"en-GB":"some text"}') + # TODO: не хватает связи со страной. ForeignKey # todo: associate user & subscriber after users registration diff --git a/apps/notification/urls/back.py b/apps/notification/urls/back.py new file mode 100644 index 00000000..2012ebe1 --- /dev/null +++ b/apps/notification/urls/back.py @@ -0,0 +1 @@ +urlpatterns = [] \ No newline at end of file diff --git a/apps/notification/views/common.py b/apps/notification/views/common.py index f7fbf9fe..257c3286 100644 --- a/apps/notification/views/common.py +++ b/apps/notification/views/common.py @@ -28,6 +28,7 @@ class SubscribeInfoView(generics.RetrieveAPIView): class SubscribeInfoAuthUserView(generics.ListAPIView): """Subscribe info auth user view.""" + # TODO: тут пользователь должен видеть свои подписки. проверь плс, что работает permission_classes = (permissions.IsAuthenticated,) serializer_class = serializers.SubscribeSerializer diff --git a/project/urls/back.py b/project/urls/back.py index e7e2b43b..8245e492 100644 --- a/project/urls/back.py +++ b/project/urls/back.py @@ -10,6 +10,7 @@ urlpatterns = [ path('gallery/', include(('gallery.urls', 'gallery'), namespace='gallery')), path('location/', include('location.urls.back')), path('news/', include('news.urls.back')), + path('notifications/', include(('notification.urls.back', 'notification'), namespace='notification')), path('review/', include('review.urls.back')), path('tags/', include(('tag.urls.back', 'tag'), namespace='tag')), path('products/', include(('product.urls.back', 'product'), namespace='product')),