From 11e037f699a5bb2b03226803e0a59816adc6befd Mon Sep 17 00:00:00 2001 From: Anatoly Date: Fri, 31 Jan 2020 13:21:00 +0300 Subject: [PATCH] modified permissions for tags --- apps/tag/views.py | 20 ++++++++------------ 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/apps/tag/views.py b/apps/tag/views.py index 8e22f9e4..e7f151c0 100644 --- a/apps/tag/views.py +++ b/apps/tag/views.py @@ -4,7 +4,6 @@ from django.contrib.contenttypes.models import ContentType from django.utils.translation import gettext_lazy as _ from rest_framework import generics, mixins, permissions, status, viewsets from rest_framework.decorators import action -from rest_framework.permissions import IsAdminUser from rest_framework.response import Response from rest_framework.serializers import ValidationError @@ -12,9 +11,8 @@ from location.models import WineRegion from product.models import ProductType from search_indexes import views as search_views from tag import filters, models, serializers -from utils.permissions import ( - IsEstablishmentManager -) +from utils.methods import get_permission_classes +from utils.permissions import IsEstablishmentManager class ChosenTagsView(generics.ListAPIView, viewsets.GenericViewSet): @@ -56,11 +54,12 @@ class TagCategoryViewSet(mixins.ListModelMixin, viewsets.GenericViewSet): """ViewSet for TagCategory model.""" filterset_class = filters.TagCategoryFilterSet - pagination_class = None - permission_classes = (permissions.AllowAny,) queryset = models.TagCategory.objects.with_tags().with_base_related(). \ distinct() serializer_class = serializers.TagCategoryBaseSerializer + permission_classes = get_permission_classes( + IsEstablishmentManager, + ) # User`s views & viewsets @@ -338,13 +337,13 @@ class TagBackOfficeViewSet(mixins.ListModelMixin, mixins.CreateModelMixin, """List/create tag view.""" pagination_class = None - permission_classes = [ - IsAdminUser, IsEstablishmentManager - ] queryset = models.Tag.objects.with_base_related() serializer_class = serializers.TagBackOfficeSerializer bind_object_serializer_class = serializers.TagBindObjectSerializer chosen_serializer_class = serializers.ChosenTagBindObjectSerializer + permission_classes = get_permission_classes( + IsEstablishmentManager, + ) def perform_binding(self, serializer): data = serializer.validated_data @@ -397,9 +396,6 @@ class TagCategoryBackOfficeViewSet(mixins.CreateModelMixin, queryset = TagCategoryViewSet.queryset.with_extended_related() serializer_class = serializers.TagCategoryBackOfficeDetailSerializer bind_object_serializer_class = serializers.TagCategoryBindObjectSerializer - permission_classes = [ - IsAdminUser, IsEstablishmentManager - ] def perform_binding(self, serializer): data = serializer.validated_data