fixed related news, but in future need refactoring

This commit is contained in:
Anatoly 2019-11-03 01:32:24 +03:00
parent 248ab103a1
commit 201dd40193
2 changed files with 17 additions and 5 deletions

View File

@ -189,11 +189,11 @@ class News(BaseAttributes, TranslatedFieldsMixin):
@property
def should_read(self):
return self.__class__.objects.should_read(self)[:3]
return self.__class__.objects.should_read(self)
@property
def same_theme(self):
return self.__class__.objects.same_theme(self)[:3]
return self.__class__.objects.same_theme(self)
@property
def main_image(self):

View File

@ -203,8 +203,8 @@ class NewsDetailSerializer(NewsBaseSerializer):
class NewsDetailWebSerializer(NewsDetailSerializer):
"""News detail serializer for web users.."""
same_theme = NewsSimilarListSerializer(many=True, read_only=True)
should_read = NewsSimilarListSerializer(many=True, read_only=True)
same_theme = serializers.SerializerMethodField()
should_read = serializers.SerializerMethodField()
agenda = AgendaSerializer()
banner = NewsBannerSerializer()
@ -215,9 +215,21 @@ class NewsDetailWebSerializer(NewsDetailSerializer):
'same_theme',
'should_read',
'agenda',
'banner'
'banner',
)
#todo: refactor this
def get_same_theme(self, obj):
return NewsSimilarListSerializer(
obj.same_theme.has_translation(self.context.get('request').locale)[:3],
many=True).data
#todo: refactor this
def def_should_read(self, obj):
return NewsSimilarListSerializer(
obj.should_read.has_translation(self.context.get('request').locale)[:3],
many=True).data
class NewsBackOfficeBaseSerializer(NewsBaseSerializer):
"""News back office base serializer."""