change translation mechanics

This commit is contained in:
Anatoly 2019-11-03 17:00:10 +03:00
parent c50cd7c693
commit 4f89d7603e
4 changed files with 6 additions and 17 deletions

View File

@ -189,11 +189,11 @@ class News(BaseAttributes, TranslatedFieldsMixin):
@property
def should_read(self):
return self.__class__.objects.should_read(self)
return self.__class__.objects.should_read(self)[:3]
@property
def same_theme(self):
return self.__class__.objects.same_theme(self)
return self.__class__.objects.same_theme(self)[:3]
@property
def main_image(self):

View File

@ -203,8 +203,8 @@ class NewsDetailSerializer(NewsBaseSerializer):
class NewsDetailWebSerializer(NewsDetailSerializer):
"""News detail serializer for web users.."""
same_theme = serializers.SerializerMethodField()
should_read = serializers.SerializerMethodField()
same_theme = NewsSimilarListSerializer(many=True, read_only=True)
should_read = NewsSimilarListSerializer(many=True, read_only=True)
agenda = AgendaSerializer()
banner = NewsBannerSerializer()
@ -218,18 +218,6 @@ class NewsDetailWebSerializer(NewsDetailSerializer):
'banner',
)
#todo: refactor this
def get_same_theme(self, obj):
return NewsSimilarListSerializer(
obj.same_theme.has_translation(self.context.get('request').locale)[:3],
many=True).data
#todo: refactor this
def get_should_read(self, obj):
return NewsSimilarListSerializer(
obj.should_read.has_translation(self.context.get('request').locale)[:3],
many=True).data
class NewsBackOfficeBaseSerializer(NewsBaseSerializer):
"""News back office base serializer."""

View File

@ -22,7 +22,6 @@ class NewsMixinView:
"""Override get_queryset method."""
qs = models.News.objects.published() \
.has_translation(self.request.locale) \
.with_base_related() \
.order_by('-is_highlighted', '-created')
country_code = self.request.country_code

View File

@ -78,6 +78,8 @@ def translate_field(self, field_name):
# fallback
if value is None:
value = field.get(get_default_locale())
if value is None:
value = field.get(next(iter(field.keys())))
return value
return None
return translate