From e6094b7961c1d2b81dec92d5c1f0afccfd66e2cd Mon Sep 17 00:00:00 2001 From: littlewolf Date: Wed, 6 Nov 2019 09:03:48 +0300 Subject: [PATCH] Fix RUD Remove Create Serializer --- apps/location/serializers/common.py | 13 ------------- apps/location/urls/common.py | 3 +-- apps/location/views/common.py | 7 +------ 3 files changed, 2 insertions(+), 21 deletions(-) diff --git a/apps/location/serializers/common.py b/apps/location/serializers/common.py index fe630c7d..2a70c3b8 100644 --- a/apps/location/serializers/common.py +++ b/apps/location/serializers/common.py @@ -84,19 +84,6 @@ class CitySerializer(serializers.ModelSerializer): ] -class CityCreateSerializer(serializers.ModelSerializer): - """City create serializer""" - class Meta: - model = models.City - fields = [ - 'name', - 'country', - 'code', - 'region', - 'is_island' - ] - - class AddressBaseSerializer(serializers.ModelSerializer): """Serializer for address obj in related objects.""" diff --git a/apps/location/urls/common.py b/apps/location/urls/common.py index 8c91ca58..edff6122 100644 --- a/apps/location/urls/common.py +++ b/apps/location/urls/common.py @@ -9,9 +9,8 @@ urlpatterns = [ path('addresses/', views.AddressListView.as_view(), name='address-list'), path('addresses//', views.AddressRetrieveView.as_view(), name='address-retrieve'), - path('cities/', views.CityListView.as_view(), name='city-list'), + path('cities/', views.CityListCreateView.as_view(), name='city-list'), path('cities//', views.CityRUDView.as_view(), name='city-detail'), - path('cities/create/', views.CityCreateView.as_view(), name='city-create'), path('countries/', views.CountryListView.as_view(), name='country-list'), path('countries//', views.CountryRetrieveView.as_view(), name='country-retrieve'), diff --git a/apps/location/views/common.py b/apps/location/views/common.py index a4b598c4..f3e3be7e 100644 --- a/apps/location/views/common.py +++ b/apps/location/views/common.py @@ -71,14 +71,9 @@ class RegionUpdateView(RegionViewMixin, generics.UpdateAPIView): # City -class CityCreateView(CityViewMixin, generics.CreateAPIView): - """Create view for model City""" - permission_classes = (permissions.AllowAny,) - serializer_class = serializers.CityCreateSerializer - - class CityRUDView(generics.RetrieveUpdateDestroyAPIView): serializer_class = serializers.CitySerializer + permission_classes = (permissions.AllowAny,) # TODO: remove after tests class CityRetrieveView(CityViewMixin, generics.RetrieveAPIView):